Conversation
Rotheem
force-pushed
the
mypayment-extended
branch
from
9cc4c12 to
1e78c9d
Compare
Rotheem
force-pushed
the
mypayment-extended
branch
from
b774157 to
159040a
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Rotheem
force-pushed
the
mypayment-extended
branch
from
3067516 to
50fa93e
Compare
Rotheem
force-pushed
the
mypayment-extended
branch
from
5e02895 to
7fe4cd1
Compare
armanddidierjean
left a comment
armanddidierjean
left a comment
There was a problem hiding this comment.
We could create a method that would allow to call either request_transaction or request_store_transfer. Maybe it could be a good idea to separate mypayment internal and public utils
| message = Message( | ||
| title=f"💸 Nouvelle demande de paiement - {request_info.name}", | ||
| content=f"Une nouvelle demande de paiement de {request_info.total / 100} € attend votre validation", | ||
| action_module=settings.school.payment_name, |
There was a problem hiding this comment.
This should be the module root
| name: str | ||
| note: str | None |
There was a problem hiding this comment.
Could we clarify a bit this part? Maybe store_note like in RequestEdit?
There was a problem hiding this comment.
It would be great to be able to define different notes for the user and for the store
There was a problem hiding this comment.
store_transaction_descriptionanduser_transaction_description?
|
|
||
| **The user must be authenticated to use this endpoint** | ||
| """ | ||
| await cruds_mypayment.mark_expired_requests_as_expired( |
There was a problem hiding this comment.
Does this mean that this specific endpoint need to be called for request to have the correct status?
| payment_info: schemas_mypayment.PaymentInfo, | ||
| user: schemas_users.CoreUser, |
There was a problem hiding this comment.
Why are some fields directly a param of request_payment while others are embeded in payment_info?
| name: str | ||
| note: str | None |
There was a problem hiding this comment.
It would be great to be able to define different notes for the user and for the store
| class RequestInfo(BaseModel): | ||
| store_id: UUID | ||
| total: int | ||
| name: str |
There was a problem hiding this comment.
Could you clarify where this field will be used? Maybe request_name
| name: str | ||
| note: str | None |
There was a problem hiding this comment.
store_transaction_descriptionanduser_transaction_description?
3 participants
Description
Please explain the changes you made here.
Checklist